On Fri, Aug 20, 2010 at 12:11 AM, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote: > > Ah, I see. But I think the static variable should stay declared outside > of the function scope, with a nice comment explaining why it's not > initialized at init-time. > > Hiding global state in function code is usually frowned upon. > I don't agree with you. We'd better not expose the variable which isn't expected to be used by others. If not, maybe someone will misuse it. The user should only reply on the interface, but not the internal implementation. Thanks. -- Regards, Changli Gao(xiaosuo@xxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
