On 15/08/10 15:16, David Miller wrote:
From: Stephen Buck<stephen.buck@xxxxxxxxxx>
Date: Sat, 14 Aug 2010 14:35:21 +1000
+ }
+ if (!node)
+ tb = inet_bind_bucket_create(table->bind_bucket_cachep,
+ sock_net(sk), head, port);
+ }
sk_add_bind_node(child,&tb->owners);
inet_bind_bucket_create() can fail due to memory allocation failure,
you're therefore going to have to find a way to handle that.
And in doing so you're going to find out that there is no easy
way out of this code path in such an error, this code was
absolutely not designed to be able to handle cases like this.
You're right. I didn't cover the failure case. And no, it doesn't look easy.
I'll have another look at the problem when I get a chance.
Thanks for pointing it out.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
