Re: [PATCH 2/2] nf_nat: don't check if the tuple is unique when there isn't any other choice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 31, 2010 at 10:03 PM, Jan Engelhardt <jengelh@xxxxxxxxxx> wrote:
>
> On Saturday 2010-07-31 04:22, Changli Gao wrote:
>>+++ b/net/ipv4/netfilter/nf_nat_proto_common.c
>>@@ -81,9 +81,9 @@ void nf_nat_proto_unique_tuple(struct nf_conntrack_tuple *tuple,
>>       else
>>               off = *rover;
>>
>>-      for (i = 0; i < range_size; i++, off++) {
>>+      for (i = 0; 1; off++) {
>
> The 1 looks strange. It's more common to express this without
> a condition, as in (i = 0; ; ++off).
>
>

OK, Thanks.

-- 
Regards,
Changli Gao(xiaosuo@xxxxxxxxx)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux