On Saturday 2010-07-31 04:15, Changli Gao wrote: >the only user of unique_tuple() get_unique_tuple() doesn't care about the >return value of unique_tuple(), so make unique_tuple() return void (nothing). Shouldn't the callers (get_unique_tuple in nf_nat_core.c) ideally return NF_DROP or something such that connections that cannot be uniquely mangled be rejected rather than forwarded without mangling? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html