Le vendredi 23 juillet 2010 à 14:47 +0800, Changli Gao a écrit : > On Fri, Jul 23, 2010 at 2:29 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > > Le vendredi 23 juillet 2010 à 11:34 +0800, Changli Gao a écrit : > >> iptables: use skb->len for accounting > >> > >> use skb->len for accounting as xt_quota does. > >> > > > > Why ? > > > > This is a gratuitous change, unless you have very strong arguments. > > > > xt_quota is an exception, dont change all others because of it ! > > exception ? Why ? Because it handles all protocols... So skb->len is a shortcut, an approximation if you want. At IPV4 level, ip->tot_len is an exact value. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
