On Friday 2010-07-23 05:31, Changli Gao wrote: >ip6tables: use skb->len for accounting > >ipv6_hdr(skb)->payload_len is ZERO and can't be used for accounting, if the >payload is a Jumbo Payload specified in RFC2675. > >Signed-off-by: Changli Gao <xiaosuo@xxxxxxxxx> >---- > net/ipv6/netfilter/ip6_tables.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c >index dc41d6d..33113c1 100644 >--- a/net/ipv6/netfilter/ip6_tables.c >+++ b/net/ipv6/netfilter/ip6_tables.c >@@ -387,9 +387,7 @@ ip6t_do_table(struct sk_buff *skb, > goto no_match; > } > >- ADD_COUNTER(e->counters, >- ntohs(ipv6_hdr(skb)->payload_len) + >- sizeof(struct ipv6hdr), 1); >+ ADD_COUNTER(e->counters, skb->len, 1); > > t = ip6t_get_target_c(e); > IP_NF_ASSERT(t->u.kernel.target); >-- I wonder how this fares with trailing padding or data, like, when you have a standard v4/v6 packet created in a raw socket, and append a bunch of \0s to it. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
