On Wed, Jul 14, 2010 at 02:23:01PM +0200, Patrick McHardy wrote: > On 10.07.2010 05:16, Simon Horman wrote: > > I initially noticed this because of the compiler warning below, but it does > > seem to be a valid concern in the case where ct_sip_get_header() returns 0 > > in the first iteration of the while loop. > > > > net/netfilter/nf_conntrack_sip.c: In function 'sip_help_tcp': > > net/netfilter/nf_conntrack_sip.c:1379: warning: 'ret' may be used uninitialized in this function > > Thanks Simon. I've applied the patch, but changed NF_DROP to > NF_ACCEPT since we should avoid dropping packets with unknown > contents (not SIP) if possible. Thanks, to be honest I was a bit unsure of what policy was best. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
