Re: [PATCH 1/3] netfilter: Expose connection tracking accounting toggles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 2010-06-24 17:27, Tim Gardner wrote:
> 
>+/* Check if connection tracking accounting is enabled */
>+static inline bool nf_ct_acct_enabled(const struct xt_mtchk_param *par)
>+{
>+	return par->net->ct.sysctl_acct == 0 ? false : true;
>+}

The ? false : true part is pretty redundant. Just write

	return par->net->ct.sysctl_acct != 0;
>+
>+/* Enable/disable connection tracking accounting */
>+static inline void nf_ct_set_acct(const struct xt_mtchk_param *par, bool enable)
>+{
>+	par->net->ct.sysctl_acct = enable == true ? 1 : 0;

par->net->ct.sysctl_acct = enable;


>+}
>+
> extern int nf_conntrack_acct_init(struct net *net);
> extern void nf_conntrack_acct_fini(struct net *net);
> 
>-- 
>1.7.0.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux