On Thursday 2010-06-10 15:32, Luciano Coelho wrote: > >> I also agree that it makes more sense to lookup and store the timer in >> the targe. > >One quick question about this: did you mean to put it in the target info >structure, in this case struct idletimer_tg_info? So is it okay to have >internal data in this structure even though it is mostly for passing >data from the userspace to the kernel? You put a kernel-private pointer inside idletimer_tginfo, similar to what other modules do. That would also allow you to get a reference to the timer so that you do not have to call find_by_label on every idletimer_target invocation. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
