On Wed, 2010-06-02 at 21:52 +0200, Coelho Luciano (Nokia-D/Helsinki)
wrote:
> On Wed, 2010-06-02 at 21:29 +0200, ext Jan Engelhardt wrote:
> > On Wednesday 2010-06-02 21:05, Luciano Coelho wrote:
> > >> > >+ idletimer_tg_kobj = kobject_create_and_add("idletimer",
> > >> > >+ &THIS_MODULE->mkobj.kobj);
> > >> >
> > >> > Isn't this going to oops when you compile this module as =y?
> > >>
> > >> Damn, that's true. :(
> > >>
> > >> I'll investigate how to fix this.
> > >
> > >Would it be too hacky to force it to be a module (ie. add "depends on m"
> > >in Kconfig)?
> > >
> > >Besides /sys/module/xt_IDLETIMER and /sys/class/net, which we have
> > >already discarded, I can't find any other place that would make sense to
> > >add the idletimer in the kernel object hierarchy...
> >
> > While THIS_MODULE is NULL in =y mode, /sys/module/<xyz> can still exist
> > (cf. /sys/module/printk). I just don't know how to get at the kobj for
> > it, but the existence of it must mean it's there somewhere. Might ask
> > sysfs authors.
>
> Okay, good to know. My initial theory was that /sys/module/xt_IDLETIMER
> (pointed to by THIS_MODULE) would exist even if it was linked into the
> kernel itself, but now it's obvious that it doesn't.
>
> I'll investigate how printk does that.
What causes printk to appear under /sys/module even when compiled in, is
that it uses a module param. This line:
module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
...is what triggers the printk directory to be created in sysfs. If I
add a similar line in my module, it shows up there too.
I still don't know if there is an actual kobject associated with it,
I'll check that next.
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
