On Wednesday 2010-06-02 13:58, Luciano Coelho wrote:
>+
>+#ifndef _XT_IDLETIMER_H
>+#define _XT_IDLETIMER_H
>+
>+#define MAX_LABEL_SIZE 32
>+
>+struct idletimer_tg_info {
>+ unsigned int timeout;
>+
>+ char label[MAX_LABEL_SIZE];
>+};
As per "Writing Netfilter Modules" e-book, using "int" is a no-no.
>
>+config NETFILTER_XT_TARGET_IDLETIMER
>+ tristate "IDLETIMER target support"
depends on NETFILTER_ADVANCED
>xt_IDLETIMER.c
>+struct idletimer_tg_attr {
>+ struct attribute attr;
>+ ssize_t (*show)(struct kobject *kobj,
>+ struct attribute *attr, char *buf);
>+};
Some indent seems to have gone wrong.
>+ attr->attr.name = kstrdup(info->label, GFP_KERNEL);
Need to check return value!
>+ attr->attr.mode = 0444;
attr->attr.mode = S_IRUGO;
>+static struct xt_target idletimer_tg __read_mostly = {
>+ .name = "IDLETIMER",
>+ .family = NFPROTO_IPV4,
NFPROTO_UNSPEC
>+ .target = idletimer_tg_target,
>+ .targetsize = sizeof(struct idletimer_tg_info),
>+ .checkentry = idletimer_tg_checkentry,
>+ .destroy = idletimer_tg_destroy,
>+ .me = THIS_MODULE,
>+};
>+
>+static int __init idletimer_tg_init(void)
>+{
>+ int ret;
>+
>+ idletimer_tg_kobj = kobject_create_and_add("idletimer",
>+ &THIS_MODULE->mkobj.kobj);
>+ if (!idletimer_tg_kobj)
>+ return -ENOMEM;
>+
>+ /* FIXME: do we want to keep it in the module or in the net class? */
I have only ever seen interfaces in /sys/class/net, so it might be
wise to keep it that way in light of scripts doing
echo /sys/class/net/* to get a list of interfaces.
Looks quite ok.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
