Jan Engelhardt wrote: > On Friday 2010-05-14 20:13, Patrick McHardy wrote: >> Jason Gunthorpe wrote: >>> At least the XEN net front driver always produces non linear skbs, >>> so the SIP module does nothing at all when used with that NIC. >>> >>> Unconditionally linearize the skb.. >>> >>> Signed-off-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> >>> --- >>> net/netfilter/nf_conntrack_sip.c | 9 +++------ >>> 1 files changed, 3 insertions(+), 6 deletions(-) >>> >>> Patrick/Jan, thanks.. This is what I wanted to do in the first place, >>> but I couldn't convince myself it was safe, as no other nf code does >>> this.. >> Your patch is based on an old version, the current version also >> supports TCP. I'll commit this patch to my tree after some testing. > > nf_defrag defragments the packets, but then they're still non-linear? > I'm clearly missing something, could somenoe elaborate? We're talking about packets with non-linear data, which is unrelated to fragments. Reassembled fragments are non-linear as well though. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
