On Wednesday 2010-05-12 18:29, Stephen Hemminger wrote:
>Make sure all printk messages have a severity level.
>
>--- a/net/netfilter/nf_conntrack_amanda.c 2010-05-12 09:28:26.447006714 -0700
>+++ b/net/netfilter/nf_conntrack_amanda.c 2010-05-12 09:28:44.287371327 -0700
>@@ -108,7 +108,7 @@ static int amanda_help(struct sk_buff *s
> dataoff = protoff + sizeof(struct udphdr);
> if (dataoff >= skb->len) {
> if (net_ratelimit())
>- printk("amanda_help: skblen = %u\n", skb->len);
>+ printk(KERN_ERR "amanda_help: skblen = %u\n", skb->len);
A good idea, but perhaps we should just use pr_{err,andsoon} while at it.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
