Le lundi 03 mai 2010 à 11:16 -0700, Paul E. McKenney a écrit : > I would be happy to if I could find the commit creating > hlist_for_each_entry_continue_rcu()... > > I do see a ca. 2008 patch from Stephen Hemminger: > > http://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg264661.html > > According to http://patchwork.ozlabs.org/patch/47997/, this is > going up the networking tree as of March 18, 2010. > > So I would be happy to push the patch below, but to do so, I will need > to adopt the portion of Stephen's patch that created this primitive. > Hmm, I realize there is a true bug introduced by Stephen patch Then, net-next-2.6 doesnt yet have your commit Paul to relax hlist_for_each_entry_rcu(), so its a bit difficult to continue the work. Thanks [PATCH net-next-2.6] net: if6_get_next() fix Must use rcu variant, we are in a rcu_read_lock_bh() section Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx> --- diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 34d2d64..16bb85c 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2979,7 +2979,7 @@ static struct inet6_ifaddr *if6_get_next(struct seq_file *seq, return ifa; while (++state->bucket < IN6_ADDR_HSIZE) { - hlist_for_each_entry(ifa, n, + hlist_for_each_entry_rcu(ifa, n, &inet6_addr_lst[state->bucket], addr_lst) { if (net_eq(dev_net(ifa->idev->dev), net)) return ifa; -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
