Simon Horman wrote: > +#define FMT_TUPLE "%u.%u.%u.%u:%u->%u.%u.%u.%u:%u/%u" > +#define ARG_TUPLE(T) NIPQUAD((T)->src.u3.ip), ntohs((T)->src.u.all), \ > + NIPQUAD((T)->dst.u3.ip), ntohs((T)->dst.u.all), \ > + (T)->dst.protonum > + > +#define FMT_CONN "%u.%u.%u.%u:%u->%u.%u.%u.%u:%u->%u.%u.%u.%u:%u/%u:%u" > +#define ARG_CONN(C) NIPQUAD((C)->caddr), ntohs((C)->cport), \ > + NIPQUAD((C)->vaddr), ntohs((C)->vport), \ > + NIPQUAD((C)->daddr), ntohs((C)->dport), \ > + (C)->protocol, (C)->state > Please use the appropriate format string (%pI4) instead of NIPQUAD. > + buf_len = sprintf(buf, "%u,%u,%u,%u,%u,%u", NIPQUAD(from.ip), > + (ntohs(port)>>8)&255, ntohs(port)&255); > + > + ct = nf_ct_get(skb, &ctinfo); > + ret = nf_nat_mangle_tcp_packet(skb, > + ct, > + ctinfo, > + start-data, > + end-start, > + buf, > + buf_len); > + > + if (ct && ct != &nf_conntrack_untracked) ct is non-NULL, otherwise we'll crash in nf_nat_mangle_tcp_packet(). Are you sure you want to mangle untracked packets above? That doesn't work when their are size changes. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
