On Tuesday 2010-04-20 14:24, Patrick McHardy wrote: >Patrick McHardy wrote: >> Also applied, thanks Jan. I'll push everything out after >> some more intensive testing. > >Not using oif was broken due to an incorrect check for a device >name, there also was a device reference leak. I took the >opportunity to convert it to notifier based device resolving. > >If a oif is given, we register a netdevice notifier to resolve >the name on NETDEV_REGISTER or NETDEV_CHANGE and unresolve it >again on NETDEV_UNREGISTER or NETDEV_CHANGE (to a different name). >The behaviour should be equivalent to the runtime resolving. > >Please review, if things are fine I'll commit the patch and >push everything out. Seems good to me. >+ priv = kmalloc(sizeof(*priv), GFP_KERNEL); >+ if (priv == NULL) >+ return -ENOMEM; >+ >+ priv->tginfo = info; >+ priv->oif = -1; >+ priv->notifier.notifier_call = tee_netdev_event; >+ >+ register_netdevice_notifier(&priv->notifier); I take it tee_tg_event gets immediately called after the registration. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
