Jan Engelhardt wrote:
> On Monday 2010-04-19 14:22, Patrick McHardy wrote:
>>> --- a/include/linux/netfilter/x_tables.h
>>> +++ b/include/linux/netfilter/x_tables.h
>>> @@ -401,6 +401,13 @@ struct xt_table_info {
>>> unsigned int hook_entry[NF_INET_NUMHOOKS];
>>> unsigned int underflow[NF_INET_NUMHOOKS];
>>>
>>> + /*
>>> + * Number of user chains. Since tables cannot have loops, at most
>>> + * @stacksize jumps (number of user chains) can possibly be made.
>>> + */
>>> + unsigned int stacksize;
>>> + unsigned int *stackptr;
>>> + void ***jumpstack;
>> ...
>>> --- a/net/netfilter/x_tables.c
>>> +++ b/net/netfilter/x_tables.c
>>> @@ -62,6 +62,9 @@ static const char *const xt_prefix[NFPROTO_NUMPROTO] = {
>>> [NFPROTO_IPV6] = "ip6",
>>> };
>>>
>>> +/* Allow this many total (re)entries. */
>>> +static const unsigned int xt_jumpstack_multiplier = 2;
>>> +
>> Why aren't you using a define instead of saving the stack size
>> in the table info?
>
> I don't see how a define does any good here. Since you were quoting
> the multiplier line, I guess you could be confusing the multiplier
> with stored stacksize. FTR, the definition is:
>
> table->stacksize := number_of_user_chains(#UC) * multiplier;
>
> Since #UC is variable, so is stacksize, and so stacksize cannot
> be replaced by a constant.
Right, thanks for the explanation. Applied.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
