Eric Dumazet wrote: > xt_hashlimit uses a central lock per hash table and suffers from > contention on some workloads. (Multiqueue NIC or if RPS is enabled) > > After RCU conversion, central lock is only used when a writer wants to > add or delete an entry. > > For 'readers', updating an existing entry, they use an individual lock > per entry. Looks good to me, thanks Eric. > -/* allocate dsthash_ent, initialize dst, put in htable and lock it */ > -static struct dsthash_ent * > -dsthash_alloc_init(struct xt_hashlimit_htable *ht, > - const struct dsthash_dst *dst) Is there a reason for moving this function downwards in the file? That unnecessarily increases the diff and makes the patch harder to review. For review purposes I moved it back up, resulting in 42 lines less diff. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
