Jan Engelhardt wrote: > +static struct xt_match state_mt_reg __read_mostly = { > + .name = "state", > + .family = NFPROTO_UNSPEC, > + .checkentry = state_mt_check, > + .match = state_mt, > + .destroy = state_mt_destroy, > + .matchsize = sizeof(struct xt_state_info), > + .me = THIS_MODULE, > }; This is the one I actually wanted to see since the subject didn't state which module is changes. The patch looks fine, however I'd prefer if in the future you'd add a changelog entry for these conversions stating why this will work properly in all cases even with arptables and ebtables using the xtables infrastructure. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html