Jan Engelhardt wrote: > On Thursday 2010-03-25 14:27, Patrick McHardy wrote: >> Fair enough, but some consistency among modules would be great. There >> are a few instances of pr_err/warning used for memory allocation errors >> or invalid parameters in this patch. > > As far as I can see, I've been consistent. > > pcregrep -r 'pr_(?!info)' net/ipv4/netfilter/ net/ipv6/netfilter/ > net/bridge/netfilter/ net/netfilter/ | grep -v pr_debug | > grep -v pr_fmt | less > > Only shows either lines outside .checkentry, or things that really > are an error, such as xt_LED.c being unable to register its ledtrigger, > which is not a "user parameter error" and thus would not be pr_info. > > If you see inconsistency, could you hint me towards it? Right, I didn't notice these were all outside of checkentry. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
