Re: [PATCH 3/9] netfilter: xtables: make use of xt_request_find_target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
> diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
> index f07d77f..0665e1b 100644
> --- a/net/ipv4/netfilter/arp_tables.c
> +++ b/net/ipv4/netfilter/arp_tables.c
> @@ -523,13 +523,11 @@ find_check_entry(struct arpt_entry *e, const char *name, unsigned int size)
>  		return ret;
>  
>  	t = arpt_get_target(e);
> -	target = try_then_request_module(xt_find_target(NFPROTO_ARP,
> -							t->u.user.name,
> -							t->u.user.revision),
> -					 "arpt_%s", t->u.user.name);
> -	if (IS_ERR(target) || !target) {
> +	target = xt_request_find_target(NFPROTO_ARP, t->u.user.name,
> +	         t->u.user.revision);
>   
Indentation according to maintainers taste, please :)

> +	if (IS_ERR(target)) {
>  		duprintf("find_check_entry: `%s' not found\n", t->u.user.name);
> -		ret = target ? PTR_ERR(target) : -ENOENT;
> +		ret = PTR_ERR(target);
>  		goto out;
>  	}



--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux