Re: [PATCH 6/8] netfilter: xtables: use only error codes for checkentry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 2010-03-20 02:02, Jan Engelhardt wrote:

>Convert the return true/false to integer codes.
>
>Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx>
>---
>--- a/net/netfilter/x_tables.c
>+++ b/net/netfilter/x_tables.c
>@@ -396,8 +396,9 @@ int xt_check_match(struct xt_mtchk_param *par,
> 		ret = par->match->checkentry(par);
> 		if (ret < 0)
> 			return ret;
>-		else if (ret == 0)
>-			return -EINVAL;
>+		else if (ret > 0)
>+			/* Flag up potential errors. */
>+			return -EIO;
> 	}
> 	return 0;
> }

I initially forget to do the same for xt_check_target; that's now been
done and master has been updated to


 net/netfilter/x_tables.c             |   39 ++++++++++++++++---
 ...
 82 files changed, 594 insertions(+), 581 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux