Re: [PATCH 5/9] netfilter: xtables: limit xt_mac to ethernet devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
> I do not see a point of allowing the MAC module to work with devices
> that don't possibly have one, e.g. various tunnel interfaces such as
> tun and sit.

> @@ -29,6 +30,8 @@ static bool mac_mt(const struct sk_buff *skb, const struct xt_match_param *par)
>  	const struct xt_mac_info *info = par->matchinfo;
>  	bool ret;
>  
> +	if (skb->dev == NULL || skb->dev->type != ARPHRD_ETHER)
> +		return false;

What about the ~60 ARPHRD values that are not tunnels and sit?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux