Re: [PATCH 1/1] netfilter: nf_ct_tcp: pack nf_ct_tcp_flags to match user space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 2010-03-15 17:57, Patrick McHardy wrote:
>Lutz Jaenicke wrote:
>> ---
>>  include/linux/netfilter/nf_conntrack_tcp.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/include/linux/netfilter/nf_conntrack_tcp.h b/include/linux/netfilter/nf_conntrack_tcp.h
>> index 6e135f9..9d4cf26 100644
>> --- a/include/linux/netfilter/nf_conntrack_tcp.h
>> +++ b/include/linux/netfilter/nf_conntrack_tcp.h
>> @@ -42,7 +42,7 @@ enum tcp_conntrack {
>>  struct nf_ct_tcp_flags {
>>  	__u8 flags;
>>  	__u8 mask;
>> -};
>> +} __attribute__ ((packed));
>
>I would prefer to fix userspace to use sizeof(...) instead of
>using packed structs in the kernel. AFAICT, that should also
>work on all architectures.

Yeah that's what I would have preferred too.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux