Re: [PATCH 1/1] netfilter: nf_ct_tcp: pack nf_ct_tcp_flags to match user space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 2010-03-09 17:48, Lutz Jaenicke wrote:

>On some platforms (here: Intel IXP4xx ARM big endian)
>sizeof(struct nf_ct_tcp_flags) evaluates to 4 bytes while in the user
>space code 2 bytes is hard coded.

Why does it evaluate to 4 bytes? That seems to go against all good C 
practice.

>@@ -39,7 +39,7 @@ enum tcp_conntrack {
> /* The field td_maxack has been set */
> #define IP_CT_TCP_FLAG_MAXACK_SET		0x20
> 
>-struct nf_ct_tcp_flags {
>+struct __attribute__ ((packed)) nf_ct_tcp_flags {
> 	__u8 flags;
> 	__u8 mask;
> };
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux