Bart De Schuymer <bdschuym@xxxxxxxxxx> wrote: > > First patches are minor bug fixes/preparation patches. Patch 7 is the > > main CONFIG_COMPAT hunk, 8 handles those ebtables binaries specifically > > built for 64 bit kernel (i.e. pad in userspace). > > > > Last two patches add CONFIG_COMPAT support to the targets/matches that > > need special handling (maybe I missed some, though). > > > > Tested on x86_64 with x86 userland by comparing output of 32 and 64 bit ebtables binaries. > > One little cleanup that could be done is remove the last use of MEMPRINT > and the corresponding macro in patch 5/10. Okay, I'll do that then in the next iteration. > For patch 8/10, I'd just remove the BUGPRINT line instead of adding the > compat argument to copy_counters_to_user(). Perfect, I was a bit concerned if removing it would be acceptable; thats the sole reason I added this ugly "bool compat" argument... I'll just remove it, thanks Bart. > But apart from that, the patches look ok to me (patch 10 was missing I > think). Whoops. Proabably because I ran send-email 000* . It was unchanged from v1, though (except added const qualifiers). Thanks a lot for taking the time to review this. Regards, Florian -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
