Re: [PATCH 1/4] netfilter: xtables: compact table hook functions (1/2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 2010-02-10 16:22, Patrick McHardy wrote:

>Jan Engelhardt wrote:
>> diff --git a/net/ipv4/netfilter/arptable_filter.c b/net/ipv4/netfilter/arptable_filter.c
>> index 9733760..78bb72e 100644
>> --- a/net/ipv4/netfilter/arptable_filter.c
>> +++ b/net/ipv4/netfilter/arptable_filter.c
>> @@ -53,43 +53,38 @@ static const struct xt_table packet_filter = {
>>  };
>>  
>>  /* The work comes in here from netfilter.c */
>> -static unsigned int arpt_in_hook(unsigned int hook,
>> +static unsigned int arptable_filter_hook(unsigned int hook,
>>  				 struct sk_buff *skb,
>>  				 const struct net_device *in,
>>  				 const struct net_device *out,
>>  				 int (*okfn)(struct sk_buff *))
>
>I'm fine with this patch, but can we please keep the arguments aligned
>neatly? As I said previously, I've let this slip too often, but intend
>not to in the future.

Was not sure whether that would only apply to lines modified.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux