Re: [PATCH] xtables: symmetric COMPAT_XT_ALIGN definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 2010-02-05 23:13, Alexey Dobriyan wrote:

>Rewrite COMPAT_XT_ALIGN in terms of dummy structure hack.
>Compat counters logically have nothing to do with it.
>Use ALIGN() macro while I'm at it for same types.
>
>@@ -514,7 +514,7 @@ int xt_check_target(struct xt_tgchk_param *par,
> 		    unsigned int size, u_int8_t proto, bool inv_proto)
> {
> 	if (XT_ALIGN(par->target->targetsize) != size) {
>-		pr_err("%s_tables: %s target: invalid size %Zu != %u\n",
>+		pr_err("%s_tables: %s target: invalid size %u != %u\n",
> 		       xt_prefix[par->family], par->target->name,
> 		       XT_ALIGN(par->target->targetsize), size);
> 		return -EINVAL;
>@@ -364,7 +364,7 @@ int xt_check_match(struct xt_mtchk_param *par,
> 		 * ebt_among is exempt from centralized matchsize checking
> 		 * because it uses a dynamic-size data set.
> 		 */
>-		pr_err("%s_tables: %s match: invalid size %Zu != %u\n",
>+		pr_err("%s_tables: %s match: invalid size %u != %u\n",
> 		       xt_prefix[par->family], par->match->name,
> 		       XT_ALIGN(par->match->matchsize), size);
> 		return -EINVAL;

Why are you changing this? __alignof__ still returns a size_t,
and this type promotes through the course of the ALIGN macro.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux