Re: [PATCH 1/2] nfnetlink: add netns support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 13, 2010 at 02:02:33PM +0100, Patrick McHardy wrote:
> Alexey Dobriyan wrote:

> > +	struct sock		*nfnl;
> > +	struct sock		*nfnl_stash;
> 
> Shouldn't this be contained in an ifdef(CONFIG_NETFILTER_NETLINK)
> (_MODULE) ?

No, otherwise you won't be able to start using, e. g., nfnetlink_log
module on NETFILTER_NETLINK=n kernels without reboot.

> The remaining parts look good to me.

OK, I'll resend shortly.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux