On Thu, 22 Oct 2009, Jiri Kosina wrote:
> I can see several issues with CONFIG_NF_CT_ACCT and I think it should be
> removed for the following reasons:
>
> 1) the netlink seems broken for the (CONFIG_NF_CT_ACCT unset &&
> net.netfilter.nf_conntrack_acct set) scenario. In such case,
> ctnetlink_nlmsg_size() seems to miscompute the size of the message, as
> the CTA_COUNTERS_* are not counted in at all. Seems quite serious on a
> first glance.
> 2) It has been marked as deprecated for quite some time, and was supposed
> to be removed in 2.6.29, but is apparently still with us.
> 3) Spits confusing warnings into dmesg.
>
> All this since commit 584015727a3b ("netfilter: accounting rework:
> ct_extend + 64bit counters (v4)").
>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
> ---
> Documentation/feature-removal-schedule.txt | 9 ---------
> Documentation/kernel-parameters.txt | 3 +--
> net/netfilter/Kconfig | 22 ----------------------
> net/netfilter/nf_conntrack_acct.c | 10 ----------
> net/netfilter/nf_conntrack_netlink.c | 2 --
> 5 files changed, 1 insertions(+), 45 deletions(-)
Has this one been lost? (aka "ping").
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
