Re: [PATCH 017/103] netfilter: xtables: use better unconditional check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
> The use of memcmp should enable architecture-preferred comparison
> methods, for example 64-bit comparisons that would complete in [more
> than] half the time than inspecting just each u32/char.

I don't object to the change as cleanup, but that reasoning makes
no sense. memcmp can't assume alignment, so unless there's a
version checking for compile-time known alignment, this won't happen.

Please fix up the changelog and label this as cleanup.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux