Re: [PATCH 014/103] netfilter: xtables: remove unneeded gotos in table error paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx>
> ---
>  net/ipv4/netfilter/arptable_filter.c   |    6 +-----
>  net/ipv4/netfilter/iptable_filter.c    |    6 +-----
>  net/ipv4/netfilter/iptable_mangle.c    |    6 +-----
>  net/ipv4/netfilter/iptable_raw.c       |    6 +-----
>  net/ipv4/netfilter/iptable_security.c  |    6 +-----
>  net/ipv6/netfilter/ip6table_filter.c   |    6 +-----
>  net/ipv6/netfilter/ip6table_mangle.c   |    6 +-----
>  net/ipv6/netfilter/ip6table_raw.c      |    6 +-----
>  net/ipv6/netfilter/ip6table_security.c |    6 +-----
>  9 files changed, 9 insertions(+), 45 deletions(-)
> 
> diff --git a/net/ipv4/netfilter/arptable_filter.c b/net/ipv4/netfilter/arptable_filter.c
> index 6ecfdae..87ecd3e 100644
> --- a/net/ipv4/netfilter/arptable_filter.c
> +++ b/net/ipv4/netfilter/arptable_filter.c
> @@ -127,11 +127,7 @@ static int __init arptable_filter_init(void)
>  
>  	ret = nf_register_hooks(arpt_ops, ARRAY_SIZE(arpt_ops));
>  	if (ret < 0)
> -		goto cleanup_table;
> -	return ret;
> -
> -cleanup_table:
> -	unregister_pernet_subsys(&arptable_filter_net_ops);
> +		unregister_pernet_subsys(&arptable_filter_net_ops);
>  	return ret;
>  }

This is pointless, anyone adding something to the init path
will have to undo your change. I'm not applying this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux