On Mon, Jul 27, 2009 at 20:40, Jan Engelhardt<jengelh@xxxxxxxxxx> wrote:
>
> On Monday 2009-07-27 15:48, Hannes Eder wrote:
>>+
>>+ switch (c) {
>>+ case '0': /* --ipvs */
>>+ /* Nothing to do here. */
>
> Then why add it?
In the 'default' branch is an assert(false); Call it defensive programming.
>>+ char buf[BUFSIZ];
>>+
>>+ if (family == NFPROTO_IPV4) {
>>+ if (!numeric && addr->ip == 0) {
>>+ printf("anywhere ");
>>+ return;
>>+ }
>>+ if (numeric)
>>+ strcpy(buf, xtables_ipaddr_to_numeric(&addr->in));
>>+ else
>>+ strcpy(buf, xtables_ipaddr_to_anyname(&addr->in));
>>+ strcat(buf, xtables_ipmask_to_numeric(&mask->in));
>>+ printf("%s ", buf);
>
> There is no need to use the strcpy/strcat hacks. Just directly printf it.
As the comment says: "Shamelessly copied from libxt_conntrack.c". ;)
Furthermore I think it is good that way, because
xtables_ipaddr_to_numeric writes to a local static buffer, and
xtables_ipaddr_to_numeric might get called by
xtables_ipmask_to_numeric.
>>--- /dev/null
>>+++ b/extensions/libxt_ipvs.man
>>@@ -0,0 +1,7 @@
>>+ipvs tests where the packet was modified by IPVS, i.e. is the
>>+skb_buff->ipvs_property set.
>>+.TP
>>+[\fB!\fP] \fB--ipvs
>>+Does the packet have to IPVS property?
>>+
>>+TODO: Write proper documentation.
>
> Yes.
Sir, yes, sir ;) I am working on that.
Thanks,
-Hannes
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
