Pablo Neira Ayuso wrote:
Patrick McHardy wrote:
Jozsef Kadlecsik wrote:
Hi Patrick,
A tiny patch to add nfnetlink subsys ids for nftables and ipset. :-)
Its usually frowned upon to reserve IDs that are not used yet.
We can certainly coordinate so nftables and ipset won't clash
unless we add a different subsystem (we actually did, OSF is
new in nf-next-2.6.git). But is there a reason for adding the
IPSET id at this time instead of waiting until we merge it?
I think that the problem is that Jozsef then would need to distribute a
patch for nfnetlink to add the new ipset subsystem. This would make
easier for him I think.
But there's a patch anyways until its merged, no? I mean, it doesn't
add any code, so it isn't even necessary to rebuild the kernel.
Moreover, there's a compromise to merge it so, why not include it?
As I said, IDs are usually not reserved until something is merged,
even if there is agreement to merge it. I guess there has been too
much bad experience with reserved IDs and code that never got merged.
I have to justify the patches I merge myself and so far I can't.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
