On Wed, 2009-06-10 at 21:46 +0200, Patrick McHardy wrote:
> Author: Jan Engelhardt <jengelh@xxxxxxxxxx>
> netfilter: xtables: print hook name instead of mask
> diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
> @@ -351,9 +377,13 @@ int xt_check_match(struct xt_mtchk_param *par,
> return -EINVAL;
> }
> if (par->match->hooks && (par->hook_mask & ~par->match->hooks) != 0) {
> - printk("%s_tables: %s match: bad hook_mask %#x/%#x\n",
> + char used[64], allow[64];
> +
> + printk("%s_tables: %s match: used from hooks %s, but only "
> + "valid from %s\n",
> xt_prefix[par->family], par->match->name,
> - par->hook_mask, par->match->hooks);
> + textify_hooks(used, sizeof(used), par->hook_mask),
> + textify_hooks(allow, sizeof(allow), par->match->hooks));
> return -EINVAL;
> }
> if (par->match->proto && (par->match->proto != proto || inv_proto)) {
Shouldn't all the printks in x_tables.c be pr_err or printk(KERN_ERR ?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
