Jan Engelhardt wrote: > On 2009-06-02 12:20:45, Patrick McHardy wrote: > >> On Friday 2009-05-29 19:16, Jan Engelhardt wrote: >> >>> On Friday 2009-05-29 18:20, Bart De Schuymer wrote: >>> >>>> I think it's best to fix this in the kernel if it's possible, >>>> since we don't want to break compatibility. If the fix has to be >>>> in userspace, then it must be a fix that still works for older >>>> kernels. >>>> >>>> -#define EBT_MIN_ALIGN (__alignof__(struct ebt_entry_target)) >>>> +#define EBT_MIN_ALIGN (__alignof__(struct _xt_align)) >>>> >>> Since the kernel uses xt_align already, it's best for userspace to >>> do the same. >>> >> But that doesn't work for older kernels. Please don't dismiss >> compatibility issues that easily. Sometimes things unfortunately do >> slip through, but I expect people to do their best to fix the >> problem properly when this happens. >> > > But if it gets changed back again to ebt_entry_target, it might > stop working for the combinations it currently works on. :/ > Why, ebtables userspace didn't change, which implies it will still work? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
