Re: [PATCH 2/3] netfilter: NFQUEUE: queue balancing support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick McHardy <kaber@xxxxxxxxx> wrote:
> Nice work, applied. I've made two minor cosmetic changes:
[..]
>> +	return jhash2(addr, 4, jhash_initval);
>
> I changed 4 to ARRAY_SIZE(addr)

agreed.

>> +		printk(KERN_ERR "NFQUEUE: number of queues (%u) out of range (got 
>> %u)\n",
>> +							info->queues_total, maxid);
>> +		return false;
> and these printks to use pr_err to bring the line size down.

Indeed, it looks better that way :-)

Thanks a lot Patrick.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux