Jan Engelhardt <jengelh@xxxxxxxxxx> wrote:
> On Friday 2009-06-05 03:17, Florian Westphal wrote:
> >target4_v1{
> >+ .revision = 1,
> >+ .name = "NFQUEUE",
> >+ .version = XTABLES_VERSION,
> >+ .size = XT_ALIGN(sizeof(struct xt_NFQ_info_v1)),
> >+ .userspacesize = XT_ALIGN(sizeof(struct xt_NFQ_info_v1)),
> >+ .help = NFQUEUE_help_v1,
> >+ .init = NFQUEUE_init_v1,
> >+ .parse = NFQUEUE_parse_v1,
> >+ .print = NFQUEUE_print_v1,
> >+ .save = NFQUEUE_save_v1,
> >+ .extra_opts = NFQUEUE_opts_v1,
> >+};
> >+
> >+static struct xtables_target nfqueue_target6_v1 = {
> >+ .family = NFPROTO_IPV6,
> >+ .revision = 1,
>
> You can combine these two to NFPROTO_UNSPEC, like you did to v0,
> is not it?
Hm, v1 is tied to ipv4/6 on the kernel side, thats why I wanted to make
this explicit here, too.
> >--- a/extensions/libxt_NFQUEUE.man
> >+++ b/extensions/libxt_NFQUEUE.man
> >@@ -5,8 +5,18 @@ number.
> > \fB\-\-queue\-num\fP \fIvalue\fP
> > This specifies the QUEUE number to use. Valid queue numbers are 0 to 65535. The default value is 0.
> > .PP
> >+.TP
> >+\fB\-\-queue\-balance\fP \fIvalue\fP:\fIvalue\fP
>
> Minor nitpick: "\fIvalue\fP\fB:\fP\fIvale\fP", because the : is to
> be typed verbatim.
right, will fix.
> >+This specifies a range of queues to use. Packets are then balanced across the given queues.
> >+This is useful for multicore systems: start multiple instances of the userspace program on
> >+queues x, x+1, .. x+n and use "--queue-balance x:x+n".
>
> \-\-queue\-balance here, too.
Doh -- I should have thought of that when typing this 8-/
> >+Packets belonging to the same connection are put into the same nfqueue.
> >+.PP
> > It can only be used with Kernel versions 2.6.14 or later, since it requires
> > the
> > .B
> > nfnetlink_queue
> > kernel support.
> >+.B
> >+queue-balance
> >+support was added in Linux 2.6.31.
>
> Mh, try to use \fB...\fP, as that's somehow easier to recognize given
> people are familiar with HTML.
>
> (\fBqueue-balance\fP support wa added in Linux 2.6.31.)
Agreed.
I will re-spin with these fixups after the 2.6.30 iptables release is out.
Thank you for reviewing this patch.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
