Re: [PATCH 0/1] Conntrack event generation control, kernel part

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jan,

On Tue, 12 May 2009, Jan Engelhardt wrote:

> 
> On Tuesday 2009-05-12 13:52, Jozsef Kadlecsik wrote:
> 
> >diff --git a/net/netfilter/xt_CONNMARK.c b/net/netfilter/xt_CONNMARK.c
> >index d6e5ab4..86bc5ea 100644
> >--- a/net/netfilter/xt_CONNMARK.c
> >+++ b/net/netfilter/xt_CONNMARK.c
> >+
> >+struct compat_xt_connmark_tginfo1 {
> >+	__u32 ctmark, ctmask, nfmask;
> >+	__u8 mode;
> >+	__u8 __pad1;
> >+	__u16 __pad2;
> >+};
> 
> v1 does not need a compat mode, because it does not use 'int' or 'long'.
> Note: 'compat' here means "32-bit userspace with a 64-bit kernel". It
> does not mean converting v1 to v2.

Ahh, I'm blind, thanks! And the comments on the userspace part too - I'm 
going to fix and resend the patches.

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlec@xxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux