Re: [PATCH 07/11] netfilter: xtables: reduce indent level by one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
On Saturday 2009-05-09 04:08, Amos Jeffries wrote:
Jan Engelhardt wrote:
Cosmetic only. Transformation applied:

	-if (foo) { long block; } else { short block; }
	+if (!foo) { short block; continue; } long block;

-			if (IPT_MATCH_ITERATE(e, do_match, skb, &mtpar) != 0)
-				goto no_match;
+		if (IPT_MATCH_ITERATE(e, do_match, skb, &mtpar) != 0)
+			goto no_match;
Didn't your patch just earlier remove these no_match jumps from xtables?

You are looking at patch #07/11, the gotos are removed in patch #08/11.

Ah, the weirdness introduced by splitting patches in to small tasks.
Gotcha.

Amos
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux