Eric Dumazet wrote:
Stephen Hemminger a écrit :
Not sure what the performance impact would be but simply changing tcp_lock
(in nf_conntrack_proto_tcp) to a spin_lock might get a performance boost.
I thought I heard Paul say read_locks are way slower than spin_lock.
Alternatively, going to some form of bit based hash lock might work.
I thought Patrick was OK with adding a spinlock into each nf_conn struct ?
(We shrunk this struct with the rcu_head removal)
Yes, my main concern was the further size increase.
A straight forward locking schem. We have spinlocks everywhere in kernel afterall, and
conntracking deserves this.
Just resubmit one of your prior patch perhaps ? I can dig it in a couple of hours eventually.
Yes, please.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html