[Cyrill Gorcunov - Thu, Mar 26, 2009 at 07:59:28PM +0300] | [Alexey Dobriyan - Thu, Mar 26, 2009 at 07:34:44PM +0300] | | On Thu, Mar 26, 2009 at 05:16:31PM +0100, Patrick McHardy wrote: | | > Cyrill Gorcunov wrote: | | >> Module specific data moved into per-net site and being allocated/freed | | >> during net namespace creation/deletion. For this reason module_init/exit | | >> calls added. | | > | | > This doesn't work. You can't have multiple module_init functions | | > in one module and nf_connntrack_ivp4 already includes one. | | | | I thought all sysctl code would be generic in sense it will be done | | during L3 and L4 proto registration, so all those ifdefs will be in one | | place and so on. | | | | It's a really good idea but it requires some logic to be changed -- | for example I would need some kind of net-namespace sysctl hook | so sysctl tables will be static and pinned to a particular source | file and so on. Will think about. Thanks! | | Cyrill One more problem is that several protocols share single net-namespace functionality and I either should add ref counter to eliminate double initialization. I was in idea to use kref for that (since it has all memory barriers for that) but unfortunately it doesn't has kref_test routine. Cyrill -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html