[PATCH 3/3] build: enable -Wshadow compiler flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Enable said flag and fix up the warnings (or errors, since we are
using -Werror) that it caused.

Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx>
---
 configure.ac |    2 +-
 src/main.c   |   10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/configure.ac b/configure.ac
index 0227817..4a6a0e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -96,7 +96,7 @@ regular_CFLAGS="-D_FILE_OFFSET_BITS=64 -D_REENTRANT -Wall -Waggregate-return \
 	-Wbad-function-cast -Wcast-align -Wdeclaration-after-statement \
 	-Werror -Wformat=2 -Winit-self -Winline -Wmissing-declarations \
 	-Wmissing-format-attribute -Wmissing-prototypes \
-	-Wsign-compare -Wstrict-prototypes -Wundef -Wunused \
+	-Wshadow -Wsign-compare -Wstrict-prototypes -Wundef -Wunused \
 	-Wwrite-strings -fno-strict-aliasing -pipe";
 AC_SUBST([regular_CFLAGS])
 
diff --git a/src/main.c b/src/main.c
index 2fa540c..865c19c 100644
--- a/src/main.c
+++ b/src/main.c
@@ -183,14 +183,14 @@ int main(int argc, char * const *argv)
 		goto out;
 
 	{
-		struct netlink_ctx ctx;
+		struct netlink_ctx ctx2;
 		struct cmd *cmd, *next;
 
 		list_for_each_entry_safe(cmd, next, &state.cmds, list) {
-			memset(&ctx, 0, sizeof(ctx));
-			ctx.msgs = &msgs;
-			init_list_head(&ctx.list);
-			if (do_command(&ctx, cmd) < 0)
+			memset(&ctx2, 0, sizeof(ctx2));
+			ctx2.msgs = &msgs;
+			init_list_head(&ctx2.list);
+			if (do_command(&ctx2, cmd) < 0)
 				goto out;
 			list_del(&cmd->list);
 			cmd_free(cmd);
-- 
1.6.2

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux