Hi, Patrick. Thank you for new itpables release. There are some issues I
experience with it:
1. build fails:
if i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I. -D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64 -D_REENTRANT -Wall -Waggregate-return -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wshadow -Wstrict-prototypes -Winline -pipe -DXTABLES_LIBDIR=\"/lib/xtables\" -DXTABLES_INTERNAL -I./include -I./include -I no/include -I no/include -DIPTABLES_MULTI -DNO_SHARED_LIBS=1 -O2 -march=i686 -pipe -mtune=i686 -march=pentium-m -ggdb -U_FORTIFY_SOURCE -MT iptables_static-xtables.o -MD -MP -MF ".deps/iptables_static-xtables.Tpo" -c -o iptables_static-xtables.o `test -f 'xtables.c' || echo './'`xtables.c; \
then mv -f ".deps/iptables_static-xtables.Tpo" ".deps/iptables_static-xtables.Po"; else rm -f ".deps/iptables_static-xtables.Tpo"; exit 1; fi
xtables.c: In function 'xtables_find_target':
xtables.c:641: error: 'LOAD_MUST_SUCCEED' undeclared (first use in this function)
The following simple sed fixes this issue:
sed -e 's:\<\(LOAD_MUST_SUCCEED\)\>:XTF_\1:' -i xtables.c
2. build fails with --as-needed. Patch in attachment
(iptables-1.4.3--as-needed.patch) fixes this issue.
3. http://bugzilla.netfilter.org/show_bug.cgi?id=568 is still there,
although proposed patch fixes the issue.
Could you apply this changes?
--
Peter.
=== modified file 'Makefile.am'
--- Makefile.am 2009-03-23 20:36:12 +0000
+++ Makefile.am 2009-03-23 20:37:05 +0000
@@ -26,7 +26,7 @@
# iptables, dynamic
iptables_SOURCES = iptables-standalone.c iptables.c
iptables_LDFLAGS = -rdynamic
-iptables_LDADD = -lm libiptc/libiptc.la extensions/libext4.a libxtables.la
+iptables_LDADD = libiptc/libiptc.la extensions/libext4.a libxtables.la -lm
iptables_xml_LDADD = libxtables.la
iptables_multi_SOURCES = iptables-multi.c iptables-save.c \
@@ -47,14 +47,14 @@
# iptables-multi, semi-static
iptables_static_SOURCES = ${iptables_multi_SOURCES} xtables.c
iptables_static_CFLAGS = ${iptables_multi_CFLAGS} -DNO_SHARED_LIBS=1
-iptables_static_LDADD = -lm libiptc/libiptc.la extensions/libext4.a
+iptables_static_LDADD = libiptc/libiptc.la extensions/libext4.a -lm
iptables_xml_SOURCES = iptables-xml.c
# ip6tables, dynamic
ip6tables_SOURCES = ip6tables-standalone.c ip6tables.c
ip6tables_LDFLAGS = -rdynamic
-ip6tables_LDADD = -lm libiptc/libiptc.la extensions/libext6.a libxtables.la
+ip6tables_LDADD = libiptc/libiptc.la extensions/libext6.a libxtables.la -lm
ip6tables_multi_SOURCES = ip6tables-multi.c ip6tables-save.c \
ip6tables-restore.c ip6tables-standalone.c \
@@ -74,7 +74,7 @@
# iptables-multi, semi-static
ip6tables_static_SOURCES = ${ip6tables_multi_SOURCES} xtables.c
ip6tables_static_CFLAGS = ${ip6tables_multi_CFLAGS} -DNO_SHARED_LIBS=1
-ip6tables_static_LDADD = -lm libiptc/libiptc.la extensions/libext6.a
+ip6tables_static_LDADD = libiptc/libiptc.la extensions/libext6.a -lm
bin_PROGRAMS = iptables-xml
sbin_PROGRAMS =
Attachment:
signature.asc
Description: This is a digitally signed message part
