On Thu, 19 Mar 2009, Patrick McHardy wrote:
I've planned to release the next iptables version sometime (late)
this weekend. We've had quite a lot of changes since the last
version, please test the latest version from git and report any
issues.
I just realized a bug in libiptc.c in func TC_RENAME_CHAIN.
The rename should insert the new chain name sorted, as my binary
search system / skip-list rely on it.
I don't have time to fix it until monday. Jan, feel free to fix it up
before I do...
Cheers,
Jesper Brouer
--
-------------------------------------------------------------------
MSc. Master of Computer Science
Dept. of Computer Science, University of Copenhagen
Author of http://www.adsl-optimizer.dk
-------------------------------------------------------------------
commit 6b7e7cde912a6395cb2a1f5e4b2f50cad2592b17
Author: Jesper Dangaard Brouer <hawk@xxxxxxx>
Date: Sat Mar 21 15:40:54 2009 +0100
I just realized a bug in libiptc.c in func TC_RENAME_CHAIN.
Due my bsearch/skip-list implementation.
diff --git a/libiptc/libiptc.c b/libiptc/libiptc.c
index 544a5b2..3bcae9c 100644
--- a/libiptc/libiptc.c
+++ b/libiptc/libiptc.c
@@ -2404,6 +2404,8 @@ int TC_RENAME_CHAIN(const IPT_CHAINLABEL oldname,
return 0;
}
+ /* FIXME: Bug here due to the bsearch system, new chain name
+ needs to be inserted sorted */
strncpy(c->name, newname, sizeof(IPT_CHAINLABEL));
set_changed(handle);
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
