Re: [PATCH] iptables: Add limits.h to get INT_MIN, INT_MAX, ...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
On Saturday 2009-02-21 02:25, Jan Engelhardt wrote:
On Saturday 2009-02-21 01:28, Stephen Hemminger wrote:

Fix build failure of iptables utilities on debian/ubuntu, maybe other distros.
The values INT_MIN and INT_MAX are used by many filters and these
are defined in limits.h
No this is not right IMO, limits.h should be included for the same reason you would not do that to kernel's .h files.
Instead, limits.h should go in the .c files.

I wonder what debian has different in its Glibc files that
limits.h is not included like it is for everybody else.

It works fine for me on Debian.

Anyway, of course it should be included where due.
Gawd, that led me to have clean some unnecessary includes
up beforehand, but oh well.

Could you try the "limits" branch of git://dev.medozas.de/iptables
if it compiles for you?

Unless Stephen has time to test this, I'll apply his patch. This
doesn't seem worth loosing time over.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux