Richard Purdie wrote:
On Mon, 2009-02-16 at 17:03 +0100, Patrick McHardy wrote:
Adam Nielsen wrote:
Kernel module providing implementation of LED netfilter target. Each
instance of the target appears as a led-trigger device, which can be
associated with one or more LEDs in /sys/class/leds/
Signed-off-by: Adam Nielsen <a.nielsen@xxxxxxxxxxx>
---
Thanks for the feedback Patrick - here is the updated version with
your suggestions:
- Mutexes removed - I concede that missing a blink here and there
is acceptable :-)
- KERN_ERR used for non-critical errors, all KERN_NOTICEs removed
- Split assignment out from comparison in kzalloc()
Hope this one's okay!
Apart from some minor cosmetic issues that I'm simply going to
fix up when applying, it looks fine to me. If Richard is also
ok with this I'll apply it.
Looks good to me.
Acked-by: Richard Purdie <rpurdie@xxxxxxxxxxxxxxx>
Thanks Richard.
Adam, I wanted to apply this, but I get rejects for every single
existing file. There appears to be some whitespace damage, please
resend as attachment.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
