Re: [PATCH] netfilter: xtables: add cluster match

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 2009-02-16 10:31, Pablo Neira Ayuso wrote:

>Pablo Neira Ayuso wrote:
>
>> +static int xt_cluster_seq_show(struct seq_file *s, void *v)
>> +{
>> +	unsigned long *mask = v;
>> +	seq_printf(s, "0x%8lx\n", *mask);
>                         ^^^
>Damn, this needs the dot before the 8 to fill with zero the empty
>spaces. Jan's suggestion was wrong and I forgot to check this. I'll send
>the patch again.

Wait wait, let me requote myself:

>'.' does not make sense with non-string,non-floating point numbers 
>(though it is a stdc feature it seems). I'd say "0x%08lx", for clarity.

The second '0' in "0x%08lx" is missing.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux