On Saturday 2009-02-14 21:42, Pablo Neira Ayuso wrote: >Jan Engelhardt wrote: >> On Saturday 2009-02-14 20:29, Pablo Neira Ayuso wrote: >> >>> This patch adds the iptables cluster match. This match can be used >>> to deploy gateway and back-end load-sharing clusters. >> >> All of this nice text (below) should go into libxt_cluster.man :) > >Indeed, that will go into the manpage. I have kept the iptables part >until you finish with Jamal's libxtables renaming, to avoid any >clashing. We are done and ready for release as I understood. >>> * This match mangles the skbuff pkt_type in case that it detects >>> PACKET_MULTICAST for a non-multicast address. This may be done in >>> a PKTTYPE target for this sole purpose. >>> * This match supersedes the CLUSTERIP target. >> >> The supersedes statement should also go into Kconfig. > >Yes, but I was also waiting for Patrick to tell how to proceed with >this. I think that we also have to add CLUSTERIP to the >schedule-for-removal list. We do not have to (there is still xt_state and no mention of deprecation despite xt_conntrack superseding it) - but it would be a most logical step indeed. >>> + unsigned long node_mask; >> >You mentioned cpumask_t last time, but this is neither related to NUMA >nor a CPU mask, so I prefer to keep using a long for this thing, >moreover test and set bit operations use long. > >> /** >> * @node_mask: cluster node mask >> */ Hence the need for a comment so that this misunderstanding is resolved early. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
