Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx> writes: > On Wed, 11 Feb 2009, wli@xxxxxxxxxxxxxxxxx wrote: > >> On Wed, Feb 11, 2009 at 11:19:20AM +0100, Jozsef Kadlecsik wrote: >> > /* The golden ration: an arbitrary value */ >> > -#define JHASH_GOLDEN_RATIO 0x9e3779b9 >> > +#define JHASH_GOLDEN_RATIO 0xdeadbeef >> 0xdeadbeef is a really bad choice of an arbitrary value. It is already used in multiple places. Only a few of which are currently listed in linux/poison.h and if I happened to see that number in a debug trace having to sort through all of the possible sources looks like a major pain. I don't really care what we call it but somehow 0xdeadbeef strikes me as wrong and something that will make debugging harder. Eric -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
